add support for InSAR Explorer#1330
Conversation
|
💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖 |
Reviewer's Guide by SourceryThis pull request introduces a new tool, Sequence diagram for save_explorer.py executionsequenceDiagram
participant User
participant save_explorer.py
participant readfile.py
participant save_gmt.py
User->>save_explorer.py: Executes save_explorer.py with input files and options
save_explorer.py->>readfile.py: Reads mask file (optional)
alt velocity file provided
save_explorer.py->>readfile.py: Reads velocity file
save_explorer.py->>save_explorer.py: Converts velocity data to mm
save_explorer.py->>save_gmt.py: Writes velocity data to GRD file
end
loop for each timeseries slice
save_explorer.py->>readfile.py: Reads timeseries data for slice
save_explorer.py->>save_explorer.py: Converts timeseries data to mm
save_explorer.py->>save_gmt.py: Writes timeseries data to GRD file
end
save_explorer.py-->>User: Completion message
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @mahmud1 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a test case to verify the functionality of the new
save_explorer.pyscript. - It would be helpful to include a note about the expected data format (e.g., GeoTIFF, HDF5) for the mask file.
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
+ use progressBar for a cleaner print out msg + auto grab the default velocity/mask files if available + more print out msg
yunjunz
left a comment
There was a problem hiding this comment.
Thank you @mahmud1 for the PR! I played with the InSAR Explorer a little bit today, and it's much easier to use (and more powerful as well) than the PS Time Series Viewer, so I merged your content in the insar-explorer page into the QGIS page and moved it to the front. Nice plugin!
|
🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉 |
|
Thank you @yunjunz for reviewing and approving the PR. I’m glad to hear that you found InSAR Explorer easy to use. |
Description of proposed changes
save_explorer.pyimplemented to convert time series and velocity to GRD files compatible with QGIS InSAR Explorer plugin (https://insar-explorer.readthedocs.io/). The documentation is updated accordingly.Reminders
Summary by Sourcery
New Features:
save_explorer.pyto convert time series and velocity data to GRD files for use with the QGIS InSAR Explorer plugin.