gnss: rename JPL-SIDESHOW to SIDESHOW#1240
Merged
yunjunz merged 3 commits intoinsarlab:mainfrom Jul 29, 2024
Merged
Conversation
+ utils.arg_utils.add_gnss_argument(): rename --gnss-source JPL-SIDESHOW to SIDESHOW for simplicity + objects.gnss: use "SIDESHOW" instead of "JPL-SIDESHOW" or "JPL_SIDESHOW" for all variable names and values + objects.gnss: add reference info in the code comments for GNSS_UNR/SIDESHOW, did not find citation/reference info for GNSS_ESESES, thus, did not add it yet. + docs.references.md: update to reflect the current references noted in the smallbaselineApp.cfg file. Unrelated changes: + utils.network.simulate_coherence(): convert SNR from dB to 1 for thermal decorrelation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
utils.arg_utils.add_gnss_argument(): rename--gnss-source JPL-SIDESHOWtoSIDESHOWfor simplicityobjects.gnss: useSIDESHOWinstead ofJPL-SIDESHOWorJPL_SIDESHOWfor all variable names and valuesobjects.gnss: add reference info in the code comments forGNSS_UNR/SIDESHOW, did not find citation/reference info forGNSS_ESESES, thus, did not add it yet.docs.references.md: update to reflect the current references noted in thesmallbaselineApp.cfgfile.Unrelated changes:
utils.network.simulate_coherence(): convert SNR from dB to 1 for thermal decorrelationReminders
JPL-SIDESHOWtoSIDESHOW#1228