Skip to content

optional pyfftw import for simulation.fractal.py#1191

Merged
yunjunz merged 4 commits intoinsarlab:mainfrom
avalentino:feature/no-pyfftw
May 11, 2024
Merged

optional pyfftw import for simulation.fractal.py#1191
yunjunz merged 4 commits intoinsarlab:mainfrom
avalentino:feature/no-pyfftw

Conversation

@avalentino
Copy link
Member

@avalentino avalentino commented May 10, 2024

Description of proposed changes

Implement a fallback mechanism to use scipy.fft in src/mintpy/simulation/fractal.py in case pyfftw is not available.

N.B. I have not removed pyfftw form the list of optional (test) dependencies.

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

@yunjunz yunjunz self-requested a review May 11, 2024 13:27
@yunjunz yunjunz changed the title Optional pyfftw optional pyfftw import for simulation.fractal.py May 11, 2024
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @avalentino.

@yunjunz yunjunz merged commit 9fb0c4c into insarlab:main May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants