prep_nisar: update for changes in NISAR GUNW products#1158
prep_nisar: update for changes in NISAR GUNW products#1158mirzaees merged 11 commits intoinsarlab:mainfrom
prep_nisar: update for changes in NISAR GUNW products#1158Conversation
yunjunz
left a comment
There was a problem hiding this comment.
Thanks @mirzaees. Please check the two minor comments below. @scottstanie could you take a look at the rest of the change?
|
|
||
| if inps.subset_lat: | ||
| bbox = (inps.subset_lat[0], inps.subset_lon[0], inps.subset_lat[1], inps.subset_lon[1]) | ||
| bbox = (inps.subset_lon[0], inps.subset_lat[0], inps.subset_lon[1], inps.subset_lat[1]) |
There was a problem hiding this comment.
so this isn't converting from SNWE to (left, bottom, right top), it's just fixing the ordering for (left, bottom, right, top)?
There was a problem hiding this comment.
yes the input arguments follows mintpy subsetting with two arguments --sub-lat and --sub-lon . They are ordered to make bbox here
mirzaees
left a comment
There was a problem hiding this comment.
Thanks @hfattahi @scottstanie and @yunjunz
I changed as you suggested, let's wait for some good data to test before merging
prep_nisar: update for changes in NISAR GUNW products
hfattahi
left a comment
There was a problem hiding this comment.
I agree that it will be great to test with updated GUNW before merging this PR. @jplzhan and @katia-tymofyeyeva are working on updating the GUNW test data.
Description of proposed changes