view: support scatter plot via --style scatter option#1146
Merged
Conversation
+ cli.view.create_parser(): split the new option into `--style` and `--scaltter-size` for simplicity, and for future potential extension to contours + view.plot_slice(): pack the xx/yy meshgrid calc into a sub-function `extent2meshgrid()`
view: support scatter plot via --style scatter option
yunjunz
approved these changes
Mar 9, 2024
Member
yunjunz
left a comment
There was a problem hiding this comment.
Thank you @falkamelung for the PR. The new style looks nice!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR supports the scatter plot via
matplotlib.pyplot.scatter(), in addition to the existing image plot viamatplotlib.pyplot.imshow(), forview.pysingle plot scenario. This is useful for high-resolution data with lots of holes from unsuccessful unwrapping. Plotting larger than pixel size fills holes like a low-pass filter.This is controlled via two options:
--stylewith default of image, and--scatter-sizewith default of 10 point (**2), respectively.In the image, top is regular view.py (using imshow) and bottom is

--style scatter --scatter-size 8Reminders