readfile: support GDAL int8 dtype#1083
Merged
yunjunz merged 4 commits intoinsarlab:mainfrom Sep 8, 2023
Merged
Conversation
+ add the correction int8 conversion between GDAL and NumPy in DATA_TYPE_GDAL2NUMPY/NUMPY2GDAL + add numpy_to_gdal_dtype() from dolphin + add gdal_to_numpy_dtype() from dolphin
scottstanie
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds the support of reading
int8type for files in GDAL format, as suggested by @scottstanie in #1081.add the correction
int8conversion between GDAL and NumPy inDATA_TYPE_GDAL2NUMPY/NUMPY2GDALadd
numpy_to_gdal_dtype()fromdolphinadd
gdal_to_numpy_dtype()fromdolphinI did not replace the usage of dict conversion with the two functions above yet, because
cint16/32is supported by GDAL but not in numpy yet, thus, the dict conversion may be more generic at the moment for translation purposes.Reminders
int8types from GDAL #1081