read_gdal: switch back to gdal kwargs to leverage its subsetting capability#1072
Merged
scottstanie merged 8 commits intoinsarlab:mainfrom Aug 19, 2023
Merged
read_gdal: switch back to gdal kwargs to leverage its subsetting capability#1072scottstanie merged 8 commits intoinsarlab:mainfrom
read_gdal: switch back to gdal kwargs to leverage its subsetting capability#1072scottstanie merged 8 commits intoinsarlab:mainfrom
Conversation
The bare `next` was acting as a `pass` or `continue`
This is fixed in gdal versions >3.7.0 OSGeo/gdal#8026 The issue came from passing `np.int64` objects to GDAL, which it wasnt handling properly. Regular python `int`s work find
also fix grammar for file not found
yunjunz
approved these changes
Aug 19, 2023
Member
yunjunz
left a comment
There was a problem hiding this comment.
Looks all good to me, thank you @scottstanie!
read_gdal: switch back to gdal kwargs to leverage its subsetting capability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
general quality-of-life fixes that came up while adding more GPS comparisons for UTM products (these are before those additions, it just because a big enough PR to submit)
ReadAsArrayinstead of reading everything (utils: refactor time_func.py and add s1_utils.py #661), since the errors in the comment were from this:ds.ReadAsArrayerrors whenxoff,yoffarenumpy.int64OSGeo/gdal#8026 (but can be avoided by casting to a python numeric type)update_attribute_or_notto exit earlyreadfilefunctions to allow more functions to acceptpathlib.PathsReminders