Merged
Conversation
+ dependency: add shapely to requirements.txt and setup.py file, as it's used in `objects.euler_pole.py` to plot plate motion since insarlab#935. Note that shapely is the dependency for cartopy already, so this won't really affect the mintpy installation. + docs/installation/argcomplete: replace conda with brew for bash installation, so that the bash is independent from the conda directory, which can removed more easily/frequently than /usr/local directory from brew.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
dependency: addshapelytorequirements.txtandsetup.pyfile, as it's used inobjects.euler_pole.pyto plot plate motion sinceeuler_pole: add PMM plotting functions #935. Note that 1) shapely is already a dependency for cartopy, so this won't really affect the mintpy installation; 2) shapely has been added explicitly to the dependency on conda-forge for mintpy (mintpy v1.5.2 conda-forge/mintpy-feedstock#10)docs/installation/argcomplete: replacecondawithbrewfor bash installation, so that the bash is independent of the conda directory, which can be removed more easily/frequently than/usr/local directoryfrom brew.Reminders