Fix the pad_width integral type error for spatial_filter.py -f double_difference#1015
Merged
yunjunz merged 3 commits intoinsarlab:mainfrom May 30, 2023
Merged
Fix the pad_width integral type error for spatial_filter.py -f double_difference#1015yunjunz merged 3 commits intoinsarlab:mainfrom
pad_width integral type error for spatial_filter.py -f double_difference#1015yunjunz merged 3 commits intoinsarlab:mainfrom
Conversation
+ writefile.write(): as it can be float64 in isce2. Plus, the two-band format in roipac is weird anyway and not used much anymore [in the last 3+ year if I remember it right]. + isce_utils.extract_alosStack_metadata(): make los_file optional, because 1) attribute CENTER_INCIDENCE_ANGLE is not essential, i.e. optional; and 2) los_file does not exist sometimes, as in the post-processing of alos2App
+ spatial_filter.py: Fix the np.pad() pad_width integral type error while using double_difference filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
spatial_filter.py: Fix thenp.pad()pad_widthintegral type error while using the double_difference filter, as described in double_difference yields TypeError:pad_widthmust be of integral type. #1014.writefile.write(): do not overwrite format for.hgtfile, as it can be float64 in isce2. Plus, the two-band format in roipac is weird anyway and not used much anymore [in the last 3+ years if I remember correctly].isce_utils.extract_alosStack_metadata(): make los_file optional, because 1) attribute CENTER_INCIDENCE_ANGLE is not essential, i.e. optional; and 2) los_file does not exist sometimes, as in the post-processing of alos2AppReminders
pad_widthmust be of integral type. #1014