-
Notifications
You must be signed in to change notification settings - Fork 299
Description
We've got a recipe (well, recipes) to get MintPy v1.3.1 (and PyAPS3 and PySolid) on conda-forge mostly ready to go, but there are a few things that need to be resolved before we can open the PR to conda-forge/staged-recipes.
On the technical side:
- ✔️ the conda-forge build of pykml is out of sync with the PyPI package (and
pipinstalling the repository viagit+https),- I've open Align PyKML recipe with PyKML 0.2.0 package conda-forge/pykml-feedstock#11 to address this already and am just waiting on maintainer feedback
- ✔️Conda-forge requires building from tarballs, not repos, and a lot of the CI/CD wrapped around conda-forge works best with published package (e.g., PyPI) or published releases, so we'd need a release of PyAPS3 in GitHub and/or a published version on PyPI
- Also, I'd like to better understand the relationship between
yunjunz/PyAPSandAngeliqueBenoit/pyaps3? I'm basing off ofyunjunz/PyAPSbecauseAngeliqueBenoit/pyaps3appears abandoned and @AngeliqueBenoit doesn't seem to be around?
- Also, I'd like to better understand the relationship between
- ❌ Windows builds will have to wait for a new release (at least until Add doc on install MintPy on Windows #647 is released, but some other refactoring I'll expand on in a subsequent comment/issues would help significantly)
On the organizational side:
-
We'd like your blessing to put MintPy on conda-forge (I think we got it in this comment, but it's always good to double check)
-
We need to know who to list as a maintainers of the conda-forge recipe (there will be spam)? So far I have (GitHub ids):
@yunjunz, I'm assuming you would like to be as well?
Note: This is entirely optional -- we're willing to maintain the recipe even if no one from MintPy wants too.
I'd love it if the MintPy developers would take it for a spin and let me know if you encounter any problems. I've built a linux version using the conda-forge build process locally, and uploaded it to the hyp3 conda channel for testing (mac will need to wait until it's on conda-forge as working the conda-forge pipeline locally on mac is... hard). You can set up a new conda environment with MintPy installed (recommended) like:
conda create -n conda-mintpy -c conda-forge -c hyp3 python=3.8 mintpy
conda activate mintpyOr install it into an existing environment with:
conda install -c conda-forge -c hyp3 mintpyEither should set up all the necessary paths and environment variables just like if you followed the conda install instructions.
Importantly, MintPy's test directory, with test_smallbaselineApp.py will not be included in the conda package, so if you want to run those tests, you'll need to:
conda activate conda-mintpy
git clone https://github.com/insarlab/MintPy.git
cp -r MintPy/test ${MINTPY_HOME}/../
MintPy/test/test_smallbaselineApp.pyAnd test_smallbaselineApp.py will be executed in the conda-mintpy environment against the conda-forge build of MintPy.