Use wherefrom-compat #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
reviewed
Feb 3, 2024
Contributor
coot
left a comment
There was a problem hiding this comment.
Thanks for your contribution. This will actually extend the support of wherefrom to ghc-9.4 and ghc-9.2 (I made a mistake in the README / CHANGELOG, which needs to be fixed too).
This provides a compatibility shim around the wherefrom function allowing a stable interface to be used for more versions of GHC. In particular it should insulate users of the library from future breaking changes
13b20ab to
99872f3
Compare
Contributor
Author
|
I've removed the flag and updated the README to say that we only need GHC 9.2 or newer |
coot
reviewed
Feb 5, 2024
Contributor
coot
left a comment
There was a problem hiding this comment.
Could you also update CHANGELOG.md file?
coot
approved these changes
Feb 6, 2024
Contributor
Author
|
Thanks for merging and handling the changelog! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a compatibility shim around the wherefrom function allowing a stable interface to be used for more versions of GHC.
In particular it should insulate users of the library from future breaking changes.
A nice upside is that it allows using
whereFromwhen it was first introduced rather than when it moved toGHC.InfoProv.I've added a cabal flag, so the solver can still pick versions of
basebeforewhereFromexisted