refactor(tokenizer): Use entities' new decoder #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb55
commented
Apr 13, 2023
| "preset": "ts-jest/presets/default-esm", | ||
| "testEnvironment": "node", | ||
| "coverageProvider": "v8", | ||
| "globals": { |
Collaborator
Author
There was a problem hiding this comment.
Unrelated change, but this removes a deprecation warning from ts-jest. There is no change in behavior.
Allows some logic to be simplified
Collaborator
Author
Collaborator
|
Sorry, I have no knowledge of the I am not sure about your point “The remaining use, waiting for sequences, can be removed in a future patch”. Why is it a good thing to remove that? I personally use hibernation to pass different sequences through. |
Collaborator
|
I'll have a read through 👍 |
43081j
approved these changes
May 8, 2023
Collaborator
43081j
left a comment
There was a problem hiding this comment.
sorry it took so long, i've been away recently
looks good to me, though i haven't had chance to read much into the entities package in your repo
Collaborator
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entities@4.5.0features anEntityDecoderthat implements the entity decoding logic from this module in a way that can be shared between my three projects working with HTML entities (other PRs: fb55/entities#1136, fb55/htmlparser2#1480).With this change, the main use-case for hibernation is removed. The remaining use, waiting for sequences, can be removed in a future patch, which should make it easier to follow the logic in the tokenizer (I was surprised several times by unintuitive flows while working on this PR).
Ultimately, I'd like to see both htmlparser2 and parse5 become more modular, which will make them easier to maintain, and should provide a big speed boost — https://github.com/marko-js/htmljs-parser is currently the fastest parser in https://github.com/AndreasMadsen/htmlparser-benchmark, using a modular design to great effect.