Skip to content

feat(parser): Support search element #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fb55 merged 3 commits into from
Mar 24, 2023
Merged

feat(parser): Support search element #452

fb55 merged 3 commits into from
Mar 24, 2023

Conversation

@fb55
Copy link
Collaborator

@fb55 fb55 commented Mar 13, 2022 •
edited
Loading

Not sure if this PR should be merged at this time.

The <search> element is tested in html5lib-tests, but the PR for the spec hasn't been merged yet (whatwg/html#7320). It seems like there is consensus around this spec change (see whatwg/html#7581), but we might hold off on this until the spec has actually been updated.

@fb55
feat(parser): Support search element
0de64a8 
Part of our test suite, but not actually part of the spec yet; see whatwg/html#7320
@fb55 fb55 requested a review from wooorm March 13, 2022 11:14
wooorm
wooorm reviewed Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but weird to merge something that isn’t in HTML.
Is there a way for the tests to only test what is merged?
If not, should such a “feature-flag” be proposed there?

@fb55
Copy link
Collaborator Author

fb55 commented Mar 16, 2022

It is a bit odd that this was already added to html5lib-tests. I will hold out on merging until the spec change has been merged.

@Kaleidea
Copy link

Kaleidea commented Mar 29, 2022

I will hold out on merging until the spec change has been merged.

Hello @fb55, I'm the software architect who implemented the search element for the 3 main browsers. FYI the spec has been in W3C TAG review stage for 2 months and it's very likely to take much more time as fundamental steps in the standardization guideline were missed and the result does not meet the web platform design principles yet. There is no consensus so far on how to resolve those details.

Nevertheless, as I see those details won't affect your PR.
Yours sincerely.

@fb55
Copy link
Collaborator Author

fb55 commented Mar 30, 2022

@Kaleidea Thanks a lot for the context!

@fb55
Copy link
Collaborator Author

fb55 commented Mar 24, 2023

The search element is now part of the HTML spec, so let's get this merged!

wooorm
wooorm approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!! :)

@fb55 fb55 merged commit 9c14579 into master Mar 24, 2023
@fb55 fb55 deleted the search-element branch March 24, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wooorm wooorm wooorm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fb55 @Kaleidea @wooorm