Skip to content

Bump github.com/spf13/cobra from 1.1.1 to 1.2.1#98

Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/go_modules/github.com/spf13/cobra-1.2.1
Closed

Bump github.com/spf13/cobra from 1.1.1 to 1.2.1#98
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/go_modules/github.com/spf13/cobra-1.2.1

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 5, 2021

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps github.com/spf13/cobra from 1.1.1 to 1.2.1.

Release notes

Sourced from github.com/spf13/cobra's releases.

v1.2.1

Bug fixes

  • Quickfix for spf13/cobra#1437 after v1.2.0 where parallel use of the cmd.RegisterFlagCompletionFunc() (and subsequent map) now works correctly and flag completions now work again

v1.2.0 - The completions release

🌠 v1.2.0 - The completions release

Welcome to v1.2.0 of Cobra! This release focuses on code completions, several critical bug fixes, some documentation updates, and security bumps. Upgrading should be simple but note please take note of the introduction of completions V2 and their default use. The v1 completions library is still available, but will be deprecated in the future. Please open an issue with any problems!


New Features

  • Automatically adds completion command for shell completions. If a completion command is already provided, uses that instead. This will automatically provide shell completions for bash, zsh, fish, and PowerShell spf13/cobra#1192
    • Users can configure the command auto creation:
      • disable the creation of the completion command
      • disable completion descriptions
      • disable the --no-descriptions flag for "always on" completion descriptions
  • Introduction of bash completions V2, a uniform completion approach which include completion descriptions. The V1 bash completions are still available and will be deprecated in a latter release - spf13/cobra#1146
    • Note that projects providing completion through a different command name (say a command named "complete") will continue to use v1 for their own command but will also provide cobra's implicit "completion" command which will use v2, unless of course, these projects take the time to disable the default "completion" command as noted above.
  • Commands now support context being passed to completions - spf13/cobra#1265
  • Removed dependency onmitchellh/go-homedir in favor of core Go os.UserHomeDir() - spf13/cobra@8eaca5f

Bug Fixes

  • Fix trailing whitespace not being handled in powershell completion scripts spf13/cobra#1342
  • Bash completion variable leak fix spf13/cobra#1352
  • Fish shell completions correctly ignore trailing empty lines spf13/cobra#1284
  • PowerShell completions fix for "no file comp directive" - spf13/cobra#1363
  • Custom completions now correctly handle multiple shorthand flags together - spf13/cobra#1258
  • zsh completions now correctly handle ShellDirectiveCompletionNoSpace and file completion all the time - spf13/cobra#1213
  • Multiple fixes / improvements to the fish shell support - spf13/cobra#1249
  • Fix home directory config not loading correctly - spf13/cobra#1282
  • Fix for RegisterFlagCompletionFunc as a global var not working in multi-threaded programs: spf13/cobra#1423
  • Custom completions correctly do not complete flags after args when interspersed is false #1308

Testing

Security

  • Bump viper to 1.8.1. This corrects several issues with vulnerabilities existing in the dependency tree - spf13/cobra#1433

Other

Thank you to all our amazing contributors 🐍🚀

... (truncated)

Changelog

Sourced from github.com/spf13/cobra's changelog.

Cobra Changelog

v1.1.3

  • Fix: release-branch.cobra1.1 only: Revert "Deprecate Go < 1.14" to maintain backward compatibility

v1.1.2

Notable Changes

  • Bump license year to 2021 in golden files (#1309) @​Bowbaq
  • Enhance PowerShell completion with custom comp (#1208) @​Luap99
  • Update gopkg.in/yaml.v2 to v2.4.0: The previous breaking change in yaml.v2 v2.3.0 has been reverted, see go-yaml/yaml#670
  • Documentation readability improvements (#1228 etc.) @​zaataylor etc.
  • Use golangci-lint: Repair warnings and errors resulting from linting (#1044) @​umarcor
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 5, 2021

The following labels could not be found: T:dependencies.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

Merging #98 (3d36677) into master (f4dd1f5) will increase coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   52.39%   52.65%   +0.25%     
==========================================
  Files          16       16              
  Lines        1960     1960              
==========================================
+ Hits         1027     1032       +5     
+ Misses        833      827       -6     
- Partials      100      101       +1     
Impacted Files Coverage Δ
pkg/loadtest/master.go 69.94% <0.00%> (+1.40%) ⬆️

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/spf13/cobra-1.2.1 branch from f666dd3 to 3d36677 Compare September 30, 2021 08:08
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/spf13/cobra-1.2.1 branch from 3d36677 to 2614f2a Compare November 1, 2021 15:27
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.1 to 1.2.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](spf13/cobra@v1.1.1...v1.2.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/spf13/cobra-1.2.1 branch from 2614f2a to 8298466 Compare November 1, 2021 15:35
@thanethomson
Copy link
Contributor

Superseded by #112

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 1, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/spf13/cobra-1.2.1 branch November 1, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants