Remove dependency on Tendermint Core#168
Merged
thanethomson merged 14 commits intomainfrom Jan 19, 2023
Merged
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 52.70% 60.84% +8.13%
==========================================
Files 16 18 +2
Lines 1958 2056 +98
==========================================
+ Hits 1032 1251 +219
+ Misses 825 678 -147
- Partials 101 127 +26
|
… Docker Signed-off-by: Thane Thomson <connect@thanethomson.com>
This reverts commit 207b2b7.
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
sergio-mena
approved these changes
Jan 19, 2023
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR entirely removes tm-load-test's dependency on the Tendermint Core Go package. This is temporary while Informal Systems readies its fork of Tendermint Core.
As such, some rudimentary functionality and types had to be replicated in the
loadtestpackage. This will most likely be removed in future.Instead of manually constructing a Tendermint node in an integration test, this now sets up a 4-node localnet and executes a standalone and coordinated load test against this 4-node network, while still preserving the coverage.