Skip to content

Update module name to match the repository.#108

Closed
creachadair wants to merge 1 commit intoinformalsystems:masterfrom
creachadair:mjf/update-module-name
Closed

Update module name to match the repository.#108
creachadair wants to merge 1 commit intoinformalsystems:masterfrom
creachadair:mjf/update-module-name

Conversation

@creachadair
Copy link

Since this module was moved to a new repository, the go tool complains on
import that its declared name doesn't match its requirement spec:

 module declares its path as: github.com/interchainio/tm-load-test
        but was required as: github.com/informalsystems/tm-load-test

This updates the module declaration and the internal import paths, along with
the build string injection rule in the Makefile.

Since the repository was forwarded, and all the existing issues still work at
the new address, I also updated the changelog for consistency.

(I ran into this while investigating tendermint/tendermint/issues/7032)

Since this module was moved to a new repository, the go tool complains on
import that its declared name doesn't match its requirement spec:

 module declares its path as: github.com/interchainio/tm-load-test
        but was required as: github.com/informalsystems/tm-load-test

This updates the module declaration and the internal import paths, along with
the build string injection rule in the Makefile.

Since the repository was forwarded, and all the existing issues still work at
the new address, I also updated the changelog for consistency.
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this @creachadair!

This repo does need a little TLC at the moment.

@codecov-commenter
Copy link

Codecov Report

Merging #108 (3589eec) into master (f4dd1f5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   52.39%   52.39%           
=======================================
  Files          16       16           
  Lines        1960     1960           
=======================================
  Hits         1027     1027           
  Misses        833      833           
  Partials      100      100           
Impacted Files Coverage Δ
pkg/loadtest/cli.go 7.82% <ø> (ø)
pkg/loadtest/loadtest.go 36.17% <ø> (ø)
pkg/loadtest/master.go 68.53% <ø> (ø)
pkg/loadtest/remote_slave.go 68.39% <ø> (ø)
pkg/loadtest/slave.go 53.84% <ø> (ø)
pkg/loadtest/tm_network_info.go 0.00% <ø> (ø)
pkg/loadtest/transactor.go 61.18% <ø> (ø)
pkg/loadtest/websockets.go 88.95% <ø> (ø)

@creachadair
Copy link
Author

Thanks for the review! I think you'll have to merge this, if you want to, since I do not have commit access here.

@thanethomson
Copy link
Contributor

Ah, I see our repo's configured to only accept signed commits. It won't let me merge.

@creachadair
Copy link
Author

Ah, I see our repo's configured to only accept signed commits. It won't let me merge.

Blrgh. I need to go re-figure-out how to do signed commits. I used to have to do this, but it's been a while.

@thanethomson
Copy link
Contributor

Don't worry, I can redo your changes in a separate PR - it's standard practice for us nowadays.

@creachadair
Copy link
Author

Don't worry, I can redo your changes in a separate PR - it's standard practice for us nowadays.

In that case, may I go ahead and close this without disrupting your intent?

@thanethomson
Copy link
Contributor

In that case, may I go ahead and close this without disrupting your intent?

Done with #111. Thanks for bringing this to my attention!

@creachadair creachadair deleted the mjf/update-module-name branch November 1, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants