tendermint: ensure ValidatorIndex is ≤ i32::MAX#1411
Merged
romac merged 1 commit intocometbft:mainfrom Apr 17, 2024
Merged
Conversation
During conversion from usize to ValidatorIndex first convert the value to `i32` to make sure that the value is ≤ i32::MAX. Without that intermediate conversion, `u32::MAX as usize` is successfully converted into the index.
romac
approved these changes
Apr 17, 2024
mina86
added a commit
to mina86/tendermint-rs
that referenced
this pull request
Apr 18, 2024
During conversion from usize to ValidatorIndex first convert the value to `i32` to make sure that the value is ≤ i32::MAX. Without that intermediate conversion, `u32::MAX as usize` is successfully converted into the index.
melekes
added a commit
to cometbft/cometbft-rs
that referenced
this pull request
Apr 25, 2025
melekes
added a commit
to cometbft/cometbft-rs
that referenced
this pull request
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During conversion from usize to ValidatorIndex first convert the value to
i32to make sure that the value is ≤ i32::MAX. Without that intermediate conversion,u32::MAX as usizeis successfully converted into the index..changelog/