feat(plugins/inputs/systemd_units): add pattern support#9665
Merged
sspaink merged 2 commits intoinfluxdata:masterfrom Aug 26, 2021
Merged
Conversation
Signed-off-by: David Buettner <david.buettner@siemens.com>
Signed-off-by: David Buettner <david.buettner@siemens.com>
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
- Existing tests replace Linux systemctl with dummy function. Changes only affect behavior of Linux systemctl.
- Tests would need dummy implementation of systemctl filter functionality -> suggest to keep tests as is.
resolves #9664
This code change extends the existing
systemd_unitsinputs plugin to also support Linuxsystemctl list-units PATTERNfilters.It adds a respective option for the conf file and parses/forwards it to the
os.exec.CommandtosystemctlCCLA has been signed and exchanged with @timhallinflux, ICLA has been submitted.
Thank you for feedback/suggestions/acceptance for/of the pull request.
Cheers,
David