Skip to content

fix: support 1.17 & 1.16.7 Go versions#9642

Merged
sspaink merged 8 commits intoinfluxdata:masterfrom
sspaink:updatego17
Aug 23, 2021
Merged

fix: support 1.17 & 1.16.7 Go versions#9642
sspaink merged 8 commits intoinfluxdata:masterfrom
sspaink:updatego17

Conversation

@sspaink
Copy link
Copy Markdown
Contributor

@sspaink sspaink commented Aug 17, 2021

New Go version 1.17: https://golang.org/doc/devel/release#go1.17
New Go version 1.16.7: https://golang.org/doc/devel/release#go1.16
Deprecated 1.15.8

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Aug 17, 2021
@sspaink
Copy link
Copy Markdown
Contributor Author

sspaink commented Aug 18, 2021

Gross, so many files changed. There is a change with gofmt in 1.17 to help migrate to the use of //go:build as the build flag, which allows using logical operators. make vet was failing without running go fmt ./... first. More information in the release notes: https://tip.golang.org/doc/go1.17#gofmt

@sspaink sspaink requested a review from reimda August 18, 2021 15:46
@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 18, 2021
@reimda
Copy link
Copy Markdown
Contributor

reimda commented Aug 18, 2021

Let's hold off on this for telegraf 1.19.3. I'd like to understand better why //go:build is required now.

@srebhan
Copy link
Copy Markdown
Member

srebhan commented Aug 23, 2021

@reimda maybe the release notes help. :-)

Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reimda
Copy link
Copy Markdown
Contributor

reimda commented Aug 23, 2021

More details on golang's transition plan are at https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md#transition.

As I understand it, once we start switching to go:build, we no longer support go 1.15. 1.17 will be preferred but 1.16 will be supported. 1.15 will be unsupported but might still partially work because +build lines will be kept in sync.

The next transition step will be when we switch to 1.18. At that point 1.17 will still work but 1.16 and previous won't because +build lines will be removed.

Copy link
Copy Markdown
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Make sure to announce to devs before you merge that they must be on go 1.16 or later. A quick note in #telegraf-dev would be fine.

@sspaink sspaink merged commit 3a7d9b6 into influxdata:master Aug 23, 2021
@sspaink sspaink deleted the updatego17 branch August 23, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants