fix: support 1.17 & 1.16.7 Go versions#9642
Conversation
|
Gross, so many files changed. There is a change with gofmt in 1.17 to help migrate to the use of |
|
Let's hold off on this for telegraf 1.19.3. I'd like to understand better why |
|
@reimda maybe the release notes help. :-) |
|
More details on golang's transition plan are at https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md#transition. As I understand it, once we start switching to go:build, we no longer support go 1.15. 1.17 will be preferred but 1.16 will be supported. 1.15 will be unsupported but might still partially work because +build lines will be kept in sync. The next transition step will be when we switch to 1.18. At that point 1.17 will still work but 1.16 and previous won't because +build lines will be removed. |
reimda
left a comment
There was a problem hiding this comment.
Looks good to me. Make sure to announce to devs before you merge that they must be on go 1.16 or later. A quick note in #telegraf-dev would be fine.
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
New Go version 1.17: https://golang.org/doc/devel/release#go1.17
New Go version 1.16.7: https://golang.org/doc/devel/release#go1.16
Deprecated 1.15.8