fix: flaky cookie test and failing to close fake server between tests#9608
Merged
ssoroka merged 1 commit intoinfluxdata:masterfrom Aug 17, 2021
Merged
fix: flaky cookie test and failing to close fake server between tests#9608ssoroka merged 1 commit intoinfluxdata:masterfrom
ssoroka merged 1 commit intoinfluxdata:masterfrom
Conversation
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
ssoroka
approved these changes
Aug 17, 2021
Contributor
|
@sspaink This is marked "fix:", so it seems like a candidate for the 1.19.3 patch release, but it fixes relatively new functionality that isn't in the release-1.19 branch. I just wanted to bring this up as an example of how we can't always use the "fix:" in the semantic commit message to tell us for sure if a commit is appropriate to include in a patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests for
cookie.gowere failing randomly, when checking for the expected number of time it should have authenticated sometimes the number would be less then expected and throw the error"2" is not greater than or equal to "3"link to example of a failing test.This pr fixes the tests by removing the reliance on sleep, also closes each fake http server before the next test to avoid
socket: too many open fileserror.