feat: Add rocm_smi input to monitor AMD GPUs#9602
Conversation
7fe0ca0 to
961218a
Compare
|
Hello, any feedback on this? |
Hipska
left a comment
There was a problem hiding this comment.
So basically, this is just inputs.exec + parsers.json into one? I don't see the need to add this plugin, while the same can already be achieved by setting some configurations.
As a general comment: the approach I chose was heavily inspired to the nvidia-smi plugin that was already present in Telegraf, so I went straight with that, I admittedly was not aware of the possibility to combine plugins so I can't tell if the combination of plugins you mention is enough to fullfill the case. |
I don't mind adding a plugin that just runs a program and parses the json if it's commonly used. Without a plugin for this, each user needs to go through the config process, including learning to use the exec and json plugins and coming up with a good metric format. AMD GPUs are very common so a dedicated plugin could be useful. If you can quickly make the changes Hipska requested I think we can get this into the 1.20.0 release candidate which comes out Sept 1 (tomorrow). |
7c0cd85 to
053aea5
Compare
053aea5 to
5a32ed8
Compare
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Required for all PRs:
resolves #9601
Added an input plugin to gather AMD GPUs metrics using ROCm System Management Interface rocm-smi.