Skip to content

fix: outputs.opentelemetry use headers config in grpc requests#9587

Merged
sspaink merged 1 commit intoinfluxdata:masterfrom
codeboten:codeboten/use-headers
Sep 2, 2021
Merged

fix: outputs.opentelemetry use headers config in grpc requests#9587
sspaink merged 1 commit intoinfluxdata:masterfrom
codeboten:codeboten/use-headers

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

@codeboten codeboten commented Aug 4, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

resolves issue mentioned in this comment

Updating the OpenTelemetry output plugin to pass headers configuration as metadata into grpc requests.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Aug 4, 2021
This was referenced Aug 4, 2021
Merged
Merged
@reimda
Copy link
Copy Markdown
Contributor

reimda commented Aug 5, 2021

@jacobmarble Could you take a look at this otel output change? Thanks!

@codeboten
Copy link
Copy Markdown
Contributor Author

codeboten commented Aug 9, 2021

The failing CI jobs don't appear to be directly linked with this change, if someone could give me any guidance it would be greatly appreciated.

@sspaink
Copy link
Copy Markdown
Contributor

sspaink commented Aug 9, 2021

@codeboten Your right the failing tests were unrelated and flaky tests, we will look into fixing them. In the meantime I've re-triggered the tests. The semantic version is failing because when there is only one commit it requires it to also follow the conventional commit format, do you think you could amend the git commit message to add "fix:" to it? thanks!

Overall I think the pr looks good, thanks!

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 9, 2021
@codeboten codeboten force-pushed the codeboten/use-headers branch from 0270c3b to 860b603 Compare September 2, 2021 15:43
@codeboten codeboten force-pushed the codeboten/use-headers branch from 860b603 to 45180f2 Compare September 2, 2021 15:47
@codeboten
Copy link
Copy Markdown
Contributor Author

codeboten commented Sep 2, 2021

@sspaink anything I can do to get this PR merged? It's been sitting approved for some time.

@sspaink
Copy link
Copy Markdown
Contributor

sspaink commented Sep 2, 2021

@codeboten Once the CI finishes I will merge this pr, thanks for the work!

@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Sep 2, 2021

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

@sspaink sspaink changed the title fix: outputs.opentelemetry now uses headers configuration in grpc requests fix: outputs.opentelemetry use headers config in grpc requests Sep 2, 2021
@sspaink sspaink merged commit 5a71f76 into influxdata:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ssoroka ssoroka ssoroka approved these changes

@sspaink sspaink sspaink approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codeboten @reimda @sspaink @ssoroka