Skip to content

Add queries for collecting Query Store data in Azure SQL MI#9355

Closed
andrewzayats wants to merge 17 commits intoinfluxdata:masterfrom
andrewzayats:sql_qds_mi
Closed

Add queries for collecting Query Store data in Azure SQL MI#9355
andrewzayats wants to merge 17 commits intoinfluxdata:masterfrom
andrewzayats:sql_qds_mi

Conversation

@andrewzayats
Copy link
Copy Markdown

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

Summary of PR:

Add queries for collecting Query Store runtime and wait statistics in Azure SQL MI.
This PR is based on the following PRs: 9150 and 8465.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 11, 2021
@andrewzayats
Copy link
Copy Markdown
Author

@denzilribeiro @dimitri-furman could you please review?

Comment thread plugins/inputs/sqlserver/azuresqlqueries.go Outdated
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go Outdated
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go Outdated
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go Outdated
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go Outdated
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go Outdated
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go Outdated
Comment thread plugins/inputs/sqlserver/azuresqlqueries.go Outdated
@powersj
Copy link
Copy Markdown
Contributor

powersj commented Oct 19, 2021

Hi @andrewzayats!

Thanks for this PR, I would be happy to +1 this given @dimitri-furman has approved it as well. However, there are some conflicts now. Could you please take a look at this and ping me when you have resolved them?

Thanks!

@sjwang90
Copy link
Copy Markdown
Contributor

@andrewzayats Can you please resolve the conflicts on this PR?

@dimitri-furman
Copy link
Copy Markdown

@sjwang90 my last comment on #9150 applies to this PR as well, so this can be closed, at least until there are any takers interested in completing this.

@sjwang90 sjwang90 added the help wanted Request for community participation, code, contribution label Dec 14, 2021
@sjwang90
Copy link
Copy Markdown
Contributor

Thanks @dimitri-furman! I close it but have added the help wanted label if anyone chooses to pick this up in the future.

@sjwang90 sjwang90 closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin help wanted Request for community participation, code, contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants