Added support to override metric_url in newrelic output plugin#9342
Merged
ssoroka merged 7 commits intoinfluxdata:masterfrom Jun 15, 2021
Merged
Added support to override metric_url in newrelic output plugin#9342ssoroka merged 7 commits intoinfluxdata:masterfrom
ssoroka merged 7 commits intoinfluxdata:masterfrom
Conversation
srebhan
reviewed
Jun 13, 2021
plugins/outputs/newrelic/README.md
Outdated
Comment on lines
+27
to
+32
| [Insights API Key]: https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys#user-api-key | ||
| [Insights API Key]: https://docs.newrelic.com/docs/apis/get-started/intro-apis/types-new-relic-api-keys#user-api-key |
Member
There was a problem hiding this comment.
Please revert the additional space here.
srebhan
reviewed
Jun 13, 2021
plugins/outputs/newrelic/README.md
Outdated
| ## Metric URL override to enable geographic location endpoints. | ||
| # If not set use values from the standard | ||
| # metric_url = "https://metric-api.newrelic.com/metric/v1" | ||
|
|
srebhan
reviewed
Jun 13, 2021
Member
srebhan
left a comment
There was a problem hiding this comment.
@hsinghkalsi thanks for your work. This looks almost perfect except two small formatting comments for the README. Can you please fix them, the rest looks really good to me.
Contributor
Author
|
@srebhan Thanks for the review. I have removed the newline and extra space. |
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
srebhan
approved these changes
Jun 14, 2021
Member
srebhan
left a comment
There was a problem hiding this comment.
Perfect. Thank you for the quick response.
ssoroka
approved these changes
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Added support to override Metric URL endpoint