elasticsearch output: test to show a bug handling NaN#9221
Closed
adrianlzt wants to merge 1 commit intoinfluxdata:masterfrom
Closed
elasticsearch output: test to show a bug handling NaN#9221adrianlzt wants to merge 1 commit intoinfluxdata:masterfrom
adrianlzt wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
Elasticsearch output is not able to handle "NaN" values, which are valid values (at least generated by inputs prometheus)
Contributor
Author
|
json serializer ignores math.NaN and Inf and values. |
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Contributor
Author
|
Workaround, drop NaN values. |
Contributor
Author
|
Test are passing because test avoided in the The result of the test: |
Member
|
@adrianlzt interesting. Sorry for having this sitting around for sooo long. Do you also have a fix for the issue? For example, checking explicitly for |
Contributor
Author
|
I don't have a fix, sorry |
3 tasks
Member
|
@adrianlzt can you please check if #10196 fixes your issue!? |
Member
|
Ok bugfix is in. Closing this PR... Thanks for your contribution @adrianlzt! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elasticsearch output is not able to handle "NaN" values, which are valid
values (at least generated by inputs prometheus)
This new test shows how output breaks if it receives a NaN value.
NaN values are valid, at least contemplated in the prometheus tests.
I don't provide a fix because I am not sure how this wants to be handled.