Add option for loki to use system timestamp#9114
Closed
loganmc10 wants to merge 1 commit intoinfluxdata:masterfrom
loganmc10:loki_time
Closed
Add option for loki to use system timestamp#9114loganmc10 wants to merge 1 commit intoinfluxdata:masterfrom loganmc10:loki_time
loganmc10 wants to merge 1 commit intoinfluxdata:masterfrom
loganmc10:loki_time
Conversation
Contributor
There was a problem hiding this comment.
Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla
Contributor
Author
|
!signed-cla |
ivorybilled
approved these changes
Apr 12, 2021
ssoroka
suggested changes
Apr 13, 2021
Contributor
Author
|
Fair enough, I didn't realize there was a processor that could modify the timestamp of a metric, thanks for the info |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Loki has very strict ordering requirements. You cannot submit a log line with a timestamp older than what already exists (for a matching label set).
I've been getting HTTP 400 errors from the Loki output plugin (SNMP trap input). I added a file output and I noticed that items are written to the file slightly out of order (timestamps are not always ascending).
This change adds an option (system_timestamp) to the Loki output plugin to allow it to use the system timestamp in the Loki message, rather than the metrics provided timestamp. This should mean that timestamp values are always ascending.
@eraac since you wrote the original Loki plugin