Skip to content

gopsutil: bump to fix vendoring problem#7988

Closed
Mic92 wants to merge 1 commit intoinfluxdata:masterfrom
Mic92:gopsutils
Closed

gopsutil: bump to fix vendoring problem#7988
Mic92 wants to merge 1 commit intoinfluxdata:masterfrom
Mic92:gopsutils

Conversation

@Mic92
Copy link
Copy Markdown
Contributor

@Mic92 Mic92 commented Aug 15, 2020 •
edited
Loading

This was fixed here shirou/gopsutil#889

We use go mod vendor in NixOS to archive all dependencies and allow
reproducible offline builds.

Changelog is minimal otherwise:

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@Mic92 Mic92 mentioned this pull request Aug 15, 2020
Merged
10 tasks
@Mic92
gopsutil: bump to fix vendoring problem
63e1f41 
This was fixed here shirou/gopsutil#889

We use go mod vendor in NixOS to archive all dependencies and allow
reproducible offline builds.

Changelog is minimal otherwise:

- https://github.com/shirou/gopsutil/releases/tag/v2.20.6
@Mic92
Copy link
Copy Markdown
Contributor Author

Mic92 commented Aug 15, 2020

I had to downgrade to v2.20.6 again as macOS failed after this.

@srebhan srebhan mentioned this pull request Aug 31, 2020
Closed
3 tasks
@srebhan
Copy link
Copy Markdown
Member

srebhan commented Aug 31, 2020

Hey @Mic92,

I've managed to bump gopsutils to 2.20.7 and I need that version as 2.20.6 breaks freebsd/arm for my PR. Could you please take a look at 16ecfed and 6f14bbf !?

Feel free to use the two commits in your PR!

@Mic92
Copy link
Copy Markdown
Contributor Author

Mic92 commented Aug 31, 2020

Hey @Mic92,

I've managed to bump gopsutils to 2.20.7 and I need that version as 2.20.6 breaks freebsd/arm for my PR. Could you please take a look at 16ecfed and 6f14bbf !?

Feel free to use the two commits in your PR!

It seems that 6f14bbf does not apply cleanly anymore because sys was upgraded again?

@srebhan
Copy link
Copy Markdown
Member

srebhan commented Sep 1, 2020

That's true because my package modifies the sys version, triggering the issue in the first place. However, with the inserted sys-version 2.20.7 builds as it is the last sys-version with SYS__SYSCALL. :-)
So you should be able to update the package without 6f14bbf by just using the version with go get.

If you cannot get it to work, please drop me a note and I will open a PR superseeding this one.

@Mic92
Copy link
Copy Markdown
Contributor Author

Mic92 commented Sep 2, 2020

I won't get to it soonish. You are probably faster making your own PR.

@Mic92 Mic92 closed this Sep 2, 2020
@srebhan srebhan mentioned this pull request Sep 2, 2020
Merged
3 tasks
@Mic92 Mic92 deleted the gopsutils branch September 22, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mic92 @srebhan