Add 389 directory server input by falon · Pull Request #6117 · influxdata/telegraf

falon · 2019-07-15T09:14:42Z

Required for all PRs:

Signed CLA.
Associated README.md updated.
Has appropriate unit tests.

Hello @Dodgers, thank you for the plugin #5691! 👍
I propose to add these new features:

monitor each connection details if status = true
automonitor all dbs if alldbmonitor = true
added the Directory version in tags
unified metrics all in a row

For all contributors, tell me what do you think and feel free to modify the code.
Thank you

- monitor each connection details is status = true - automonitor all dbs if alldbmonitor = true - added the Directory version in tags - unified metrics all in a row

gnulux

Many thanks for your work

glinton · 2019-07-22T22:52:18Z

Is the consensus that this take priority over (and we can close) #5691?

falon · 2019-07-23T09:24:21Z

Is the consensus that this take priority over (and we can close) #5691?

Ok for me, thank you.
If anyone would test this plugin with Grafana, I provided some dashboards here:

LDAP
LDAP DB

gnulux · 2019-07-27T19:31:11Z

Ok for me too

glinton

Thanks

plugins/inputs/ds389/README.md

glinton · 2019-09-11T14:47:01Z

plugins/inputs/ds389/README.md

+
+  # reverse metric names so they sort more naturally
+  # Defaults to false if unset, but is set to true when generating a new config
+  dbtomonitor = ["db1","db2"]


What do you think about these being filters and calling them db_include and db_exclude

telegraf/plugins/inputs/ecs/ecs.go

Line 202 in 8bc768b

filter, err := filter.NewIncludeExcludeFilter(ecs.ContainerNameInclude, ecs.ContainerNameExclude)

I didn't implement it , cause i don't understand how it works

plugins/inputs/ds389/README.md

glinton · 2019-09-11T15:14:36Z

plugins/inputs/ds389/ds389.go

+		for _, attr := range entry.Attributes {
+			if attr.Name == "connection" && status {
+				for _, thisAttr := range attr.Values {
+					elements := strings.Split(thisAttr, ":")


Verify the length of elements to avoid a potential panic when indexing the slice.

plugins/inputs/ds389/ds389.go

gnulux · 2019-09-15T12:14:05Z

I can't update this PR , do i have to create another PR ?

falon · 2019-09-16T06:48:43Z

I can't update this PR , do i have to create another PR ?

Thank you for update these changes!

I don't know if it's because I opened the PR from my username...
If the cause is this, I add you to the collaborators. I don't know if this is the right way, or if there are better way to proceed...

Thank you

glinton · 2019-09-16T15:53:30Z

I don't know if it's because I opened the PR from my username...

That is correct. falon, you need to make the changes, or grant gnulux permissions to push to your repo.

wisebaldone · 2020-05-21T01:25:46Z

Hey all, is there much of glintons requests that still need to be done / anything I can help with?

gnulux · 2020-05-21T10:28:33Z

Hi all
I think, I made all the changes requested .
Fill free to update what I missed

schlitzered · 2020-07-01T07:32:33Z

hi, not sure if this is the right place, but it seems that this plugin will not collect cache metrics.

would you please consider to also add the metrics provided by this call:

ldapsearch -D "cn=Directory Manager" -W -p 389 -h $(hostname) -x -s base -b "cn=monitor,cn=userRoot,cn=ldbm database,cn=plugins,cn=config" "(objectclass=*)"

this for example gives you "entrycachehitratio"

gnulux · 2020-08-02T23:09:12Z

hi, not sure if this is the right place, but it seems that this plugin will not collect cache metrics.

would you please consider to also add the metrics provided by this call:

ldapsearch -D "cn=Directory Manager" -W -p 389 -h $(hostname) -x -s base -b "cn=monitor,cn=userRoot,cn=ldbm database,cn=plugins,cn=config" "(objectclass=*)"

this for example gives you "entrycachehitratio"

Hi,

Sorry for the late of my answer
entrycachehitratio is already available and prefixed with the backend name : userroot_entrycachehitratio .

Regards

wisebaldone · 2020-10-20T02:52:47Z

Hey @glinton are you happy with all the changes?

glinton

I'm approving this to remove my previous block, as the majority of my previous review were addressed, though I'm no longer on the telegraf team and don't know any current patterns, etc... @reimda likely can better assist and possibly give a milestone estimate on this. Thanks for the great work!

glinton · 2020-10-20T15:13:44Z

plugins/inputs/ds389/ds389.go

+  ## Optional TLS Config
+  # tls_ca = "/etc/telegraf/ca.pem"
+  # tls_cert = "/etc/telegraf/cert.pem"
+  # tls_key = "/etc/telegraf/key.pem"
+  ## Use TLS but skip chain & host verification
  insecure_skip_verify = false


Update the example config in readme.md with this as well

glinton · 2020-10-20T15:16:48Z

plugins/inputs/ds389/ds389.go

 	}

-	version := sr.Entries[0].GetAttributeValue("version")
+	//version := sr.Entries[0].GetAttributeValue("version")


remove commented code

kayssun · 2020-12-14T08:16:34Z

Hi
Is there any update on this? This plugin would be nice to have for me.

gnulux · 2020-12-14T12:53:54Z

Hi , thanks Very long time I have been waiting to hear from the repo maintainer. rgds Le lun. 14 déc. 2020 à 09:16, Gerrit Visscher <notifications@github.com> a écrit :

…

Hi Is there any update on this? This plugin would be nice to have for me. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6117 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLDWDEL7PW5A7IPWIR32Y3SUXCXDANCNFSM4IDUX2KQ> .

wisebaldone · 2021-01-12T07:40:27Z

We could always makes this an execd based plugin instead. This would allow us to bump the go ldap plugin to v3 and add support for ldapi.

Ref: https://github.com/influxdata/telegraf/blob/master/plugins/common/shim/README.md

wisebaldone · 2021-01-18T06:48:01Z

Just gonna add that I would be willing to do the work for the execd based version if @falon is okay with it ( forking his original changes and building it into the shim).

falon · 2021-01-18T07:28:08Z

Hello, yes, it's ok for me.
Thank you

sspaink · 2021-05-13T20:49:51Z

@falon thank you for your work here, how is this plugin working as an external plugin does it satisfy your needs? Would you be ok with closing this pull request?

falon · 2021-05-14T08:35:50Z

@falon thank you for your work here, how is this plugin working as an external plugin does it satisfy your needs? Would you be ok with closing this pull request?

Hello @sspaink , maybe do you still like to add this as internal input plugin?

Yes, it works for me as external plugin. @wisebaldone create a first release for shim too, I think it works in this way.

For me is ok to use this plugin as external, anyway. @gnulux contributes a very great part on this work, so I ask his opinion.

gnulux · 2021-05-15T07:35:28Z

Ok for me too Le ven. 14 mai 2021 à 10:36, Marco Favero ***@***.***> a écrit :

…

@falon <https://github.com/falon> thank you for your work here, how is this plugin working as an external plugin does it satisfy your needs? Would you be ok with closing this pull request? Hello @sspaink <https://github.com/sspaink> , maybe do you still like to add this as internal input plugin? Yes, it works for me as external plugin. @wisebaldone <https://github.com/wisebaldone> create a first release for shim too, I think it works in this way. For me is ok to use this plugin as *external*, anyway. @gnulux <https://github.com/gnulux> contributes a very great part on this work, so I ask his opinion. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6117 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLDWDC7L4XXK62JG42S4XLTNTOHTANCNFSM4IDUX2KQ> .

powersj · 2022-01-24T20:53:47Z

Closing due to the use of an external plugin in this case.

Thanks!

google2797350_student and others added 8 commits April 6, 2019 23:29

Add plugin for 389 Directory server

f30a7eb

Prefix db attributes with dbname

735e077

Use userroot instead of netscapeRoot as default db

15c5cea

Merge branch 'master' into 389ds

29a3241

New features:

d0d5b0a

- monitor each connection details is status = true - automonitor all dbs if alldbmonitor = true - added the Directory version in tags - unified metrics all in a row

update README

52e0a75

make fmt :)

fcec9bd

update README

0833ae8

gnulux approved these changes Jul 16, 2019

View reviewed changes

glinton added the new plugin label Jul 22, 2019

glinton changed the title ~~389ds~~ Add 389 directory server input Sep 11, 2019

glinton mentioned this pull request Sep 11, 2019

Add plugin for 389 Directory server #5691

Closed

3 tasks

glinton suggested changes Sep 11, 2019

View reviewed changes

gnulux approved these changes Sep 14, 2019

View reviewed changes

Apply changes

06999a1

glinton approved these changes Oct 20, 2020

View reviewed changes

sjwang90 added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Jan 22, 2021

falon mentioned this pull request Apr 29, 2021

Update EXTERNAL_PLUGINS.md #9217

Merged

powersj closed this Jan 24, 2022

Conversation

falon commented Jul 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Required for all PRs:

Uh oh!

gnulux left a comment

Choose a reason for hiding this comment

Uh oh!

glinton commented Jul 22, 2019

Uh oh!

falon commented Jul 23, 2019

Uh oh!

gnulux commented Jul 27, 2019

Uh oh!

glinton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

glinton Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

gnulux Sep 25, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

glinton Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gnulux commented Sep 15, 2019

Uh oh!

falon commented Sep 16, 2019

Uh oh!

glinton commented Sep 16, 2019

Uh oh!

wisebaldone commented May 21, 2020

Uh oh!

gnulux commented May 21, 2020

Uh oh!

schlitzered commented Jul 1, 2020

Uh oh!

gnulux commented Aug 2, 2020

Uh oh!

wisebaldone commented Oct 20, 2020

Uh oh!

glinton left a comment

Choose a reason for hiding this comment

Uh oh!

glinton Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

glinton Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

kayssun commented Dec 14, 2020

Uh oh!

gnulux commented Dec 14, 2020 via email

Uh oh!

wisebaldone commented Jan 12, 2021

Uh oh!

wisebaldone commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

falon commented Jan 18, 2021

Uh oh!

sspaink commented May 13, 2021

Uh oh!

falon commented May 14, 2021

Uh oh!

gnulux commented May 15, 2021 via email

Uh oh!

powersj commented Jan 24, 2022

Uh oh!

Reviewers

Assignees

falon commented Jul 15, 2019 •

edited

Loading

wisebaldone commented Jan 18, 2021 •

edited

Loading