When you plan to merge this PR?

Hi.
I have a short question about this PR. In the docs you reference https://www.elastic.co/guide/en/logstash/2.4/plugins-filters-multiline.html and there they say that this multiline-implementation isn't thread-safe.
Does this also apply for this implementation in telegraf? Is it safely possible to tail multiple streams with multiline-support using this implementation?

Thanks, Lars

@lsitzmann I referenced the logstash doc because the configuration options are a heavily inspired (or rather a copy) by the logstash plugin.
With regards to thread safety, the tailer implementation is based on goroutines so it should be thread safe (take this with a grain of salt cause I'm nowhere near being a Golang expert).
Each file is individually tailed and the multi line buffering is also managed in a separate and dedicated golang channel.

• One "tailer" per file (stream?)
  

  telegraf/plugins/inputs/tail/tail.go

  Line 135 in 839ceed

  // Create a "tailer" for each file

• One golang channel per tailer (contains the multine buffer handling)
  

  telegraf/plugins/inputs/tail/tail.go

  Line 169 in 839ceed

  // create a goroutine for each "tailer"

@danielnelson : Are there any chances, that this PR will be merged soon? Currently we have to manually copy log files from several production servers because the data collected with telegraf isn't complete.
We are really looking foreward for this feature.

@javicrespo , i think channelOpen(telegraf/plugins/inputs/tail/tail.go line 212) should be initiated with true, otherwise i will get "Error in plugin: E! Error tailing file /var/log/bingocloud/cc2.log, Error: tomb: still alive"

@lijingwei9060 Should be fixed with the last commit. I've also rewritten the timeout unit test to repro the bug.

Hi again.
We are using this PR in a production environment for about one month now. We parsed about 500k lines of logfiles with it and it seems to work very reliably - at least in our configuration.
About 1% of the log-entries are multi-lines.

We'd really appreciate to switch back to an officially released version of telegraf so once again my question: is it foreseeable when this PR will make it into an release??

I've added this to the 1.12 milestone, sorry I know it is frustrating to wait for pull requests to be merged but I feel code review is required in order to keep our bug count at a reasonable level.

Hello, would really like to see this PR merged and released.

Any idea on when that may be ?

@javicrespo I think this PR needs rebasing at this point.

this PR will make it into an release?

waiting on @javicrespo to implement on top of the latest master (the merge from master might have confused things there). If not interested, we or someone else could implement this feature.

Considering that I don’t need this feature anymore and the effort to retrofit it to the latest version in master seems non-trivial to me, I’m going to pass. Feel free to pick it up 🙂

We‘d really appreciate if anyone would do the integration of this feature.
We use it on a lot of systems- and now we are stuck to and old and self-build version of telegraf.

Closing this in favor of #7309