Added Generic SQL output plugin#4205
Closed
illuusio wants to merge 1 commit intoinfluxdata:masterfrom
Closed
Conversation
ae13dfd to
8b28eb1
Compare
24b4de8 to
e95149e
Compare
|
Are you still working on this @illuusio ? |
Author
|
Yes I would if there is interest. I kind of settled to Fluentd but it's harder to maintain but supports SQL with plugin. So if there would be solution which have intree support then I'll would settle back. |
|
Would it be feasible to write an External Plugin? |
Author
|
Maybe I have to investigate that. |
Author
|
If I understood correctly It works only for Input plugins with execd. It could be done with output Exec but needs again more thinking. |
Merged
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First small word of warning. This is SQL output plugin is far from perfect. It tries to works automatically with some plugins but with some it fails miserably.
I took generic SQL input plugin and Postgres output plugin PR#3428. Then formulated them into generic SQL plugin. As I know Telegraf is made by InfluxData which makes first grade InfluxDB but there is corner cases when SQL based database is needed to store metrics. It's not fast it's more convenient.
Plugin is at very basic level as I though if it can be get in it should be extended some features in future which are missing (like transactions) and again it's not fastest way to store metrics currently!
I have tested it with Postgres and MariaDB but it should be so generic it could be used with most SQL databases.
As said above this is far from perfect and I really appreciate comments which are not about speed of SQL (I know there is several pull request for Postgres Output plugin which probably do faster) but what is missing and is this even needed output plugin.
Required for all PRs: