Skip to content

fix(inputs.postgresql): Default database definition#13602

Merged
powersj merged 3 commits intoinfluxdata:masterfrom
aleksvagachev:get_database_postgresql
Jul 12, 2023
Merged

fix(inputs.postgresql): Default database definition#13602
powersj merged 3 commits intoinfluxdata:masterfrom
aleksvagachev:get_database_postgresql

Conversation

@aleksvagachev
Copy link
Copy Markdown
Contributor

@aleksvagachev aleksvagachev commented Jul 11, 2023 •
edited
Loading

resolves #9735

  • Fixing the default DB in the absence of the "datname" field. Now the default DB definition is taken from the connection string.
  • Fixing the default database for pgbouncer. System database pgbouncer -> pgbouncer (https://www.pgbouncer.org/usage.html)

@aleksvagachev aleksvagachev changed the title fix(inputs.postgresql): Fixed the default DB definition fix(inputs.postgresql): Default database definition Jul 11, 2023
srebhan
srebhan reviewed Jul 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @aleksvagachev! I have one suggestion regarding the database extraction...

@srebhan srebhan self-assigned this Jul 12, 2023
@srebhan srebhan added fix pr to fix corresponding bug area/postgresql plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 12, 2023
@powersj powersj added the waiting for response waiting for response from contributor label Jul 12, 2023
@aleksvagachev
Copy link
Copy Markdown
Contributor Author

aleksvagachev commented Jul 12, 2023

@srebhan Thanks for the advice. Fixed getting the database through the ParseConfig function.

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jul 12, 2023
srebhan
srebhan approved these changes Jul 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thanks for the fix @aleksvagachev!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 12, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Jul 12, 2023
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Jul 12, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 3.46 % for linux amd64 (new size: 193.8 MB, nightly size 187.4 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit b20c0d7 into influxdata:master Jul 12, 2023
@github-actions github-actions bot added this to the v1.27.3 milestone Jul 12, 2023
@srebhan srebhan modified the milestones: v1.27.3, v1.28.0 Sep 11, 2023
@hloeung hloeung mentioned this pull request Sep 21, 2023
Closed
@srebhan srebhan mentioned this pull request Sep 26, 2023
Merged
@hloeung hloeung mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srebhan srebhan srebhan approved these changes

+1 more reviewer

@powersj powersj powersj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@powersj powersj

Labels

area/postgresql fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.28.0

Development

Successfully merging this pull request may close these issues.

postgresql_extensible reports wrong database name

3 participants

@aleksvagachev @powersj @srebhan