Skip to content

feat(inputs.modbus): Allow to convert coil and discrete registers to boolean#12825

Merged
srebhan merged 3 commits intoinfluxdata:masterfrom
srebhan:modbus_issue_9284
Mar 13, 2023
Merged

feat(inputs.modbus): Allow to convert coil and discrete registers to boolean#12825
srebhan merged 3 commits intoinfluxdata:masterfrom
srebhan:modbus_issue_9284

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented Mar 9, 2023

resolves #9284

This PR adds the ability to specify an output-datatype for coil and discrete registers. You can choose between UINT16 (default) and BOOL. The former is used currently and will be used as default when the datatype is omitted. The latter will case all non-zero registers to be emitted as true or false otherwise.

@telegraf-tiger telegraf-tiger bot added area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 9, 2023
@srebhan srebhan mentioned this pull request Mar 9, 2023
Closed
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 9, 2023
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Mar 9, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

powersj
powersj approved these changes Mar 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj assigned srebhan and unassigned powersj Mar 10, 2023
@srebhan srebhan merged commit 2006086 into influxdata:master Mar 13, 2023
@srebhan srebhan deleted the modbus_issue_9284 branch March 13, 2023 11:18
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
@srebhan srebhan mentioned this pull request Jun 27, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@powersj powersj powersj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srebhan srebhan

Labels

area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.26.0

Development

Successfully merging this pull request may close these issues.

[inputs.modbus] Handle coils and discrete_inputs as booleans

2 participants

@srebhan @powersj