feat(outputs.postgresql): add Postgresql output#11672
Merged
powersj merged 3 commits intoinfluxdata:masterfrom Aug 25, 2022
Merged
feat(outputs.postgresql): add Postgresql output#11672powersj merged 3 commits intoinfluxdata:masterfrom
powersj merged 3 commits intoinfluxdata:masterfrom
Conversation
81da34e to
a149806
Compare
reimda
suggested changes
Aug 24, 2022
Contributor
reimda
left a comment
There was a problem hiding this comment.
Other than the all.go issue this looks good to me
plugins/outputs/all/all.go
Outdated
| @@ -1 +1,62 @@ | |||
| package all | |||
|
|
|||
Contributor
There was a problem hiding this comment.
This is restoring all the output plugin imports. The PR also adds a separate postgresql.go import file here so I think we can get rid of this and it will continue to be imported.
Contributor
Author
There was a problem hiding this comment.
ah good catch, fixed
Functionally, this is the same as influxdata#8651. The differences are two fold right now: 1) tests all use test-containers and right now do not have the ability to use a local postgresql database 2) The tests expecting pguint extension will skip untill the testcontainer startup installs that extension.
a6c0626 to
f1307d1
Compare
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
sspaink
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionally, this is the same as #8651. The differences are two fold
right now:
to use a local postgresql database
test-container startup installs that extension.
closes: #3428
closes: #3408