Skip to content

feat(inputs.ntpq): Allow to specify reach output format#11594

Merged
MyaLongmire merged 3 commits intoinfluxdata:masterfrom
srebhan:ntpq_reach
Aug 3, 2022
Merged

feat(inputs.ntpq): Allow to specify reach output format#11594
MyaLongmire merged 3 commits intoinfluxdata:masterfrom
srebhan:ntpq_reach

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented Aug 2, 2022

resolves #2257
partially replaces #7840

This PR adds the possibility to specify the reach output format using the reach_format setting. By default the current behavior is kept, outputting the value as an octal integer just as the raw format derived from ntpq (e.g. 377). To get the decimal representation of the value use decimal (e.g. 371 ->249). More interesting is the count setting, counting the number of successful connection attempts (e.g. 371 -> 6) or the ratio setting which returns the ratio of successful attempts of the last (8) connection attempts (e.g. 371 -> 0.75).

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 2, 2022
@srebhan srebhan requested a review from powersj August 3, 2022 08:39
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 3, 2022
@MyaLongmire MyaLongmire merged commit d606899 into influxdata:master Aug 3, 2022
@srebhan srebhan deleted the ntpq_reach branch November 7, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ntpq reachability should be converted to a counter

3 participants