Skip to content

feat(inputs.ntpq): Add option to specify command flags#11593

Merged
srebhan merged 2 commits intoinfluxdata:masterfrom
srebhan:ntpq_flags
Aug 2, 2022
Merged

feat(inputs.ntpq): Add option to specify command flags#11593
srebhan merged 2 commits intoinfluxdata:masterfrom
srebhan:ntpq_flags

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented Aug 2, 2022

resolves #4746
partially replaces #7840

This PR adds an options setting to specify flags passed on to the ntpq command. This way you can both add additional flags or remove default flags (e.g. -p). Due to it's capabilities the new options setting replaces the dns_lookup option which is deprecated in the PR.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 2, 2022
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 2, 2022
@srebhan srebhan merged commit ba2ebe8 into influxdata:master Aug 2, 2022
@srebhan srebhan deleted the ntpq_flags branch November 7, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ntpq input plugin should use the -w parameter to get entire IPv6 address of remote

3 participants