Skip to content

feat: added "allow_reauth" config option for openstack client#11572

Merged
srebhan merged 4 commits intoinfluxdata:masterfrom
singamSrikar:master
Aug 2, 2022
Merged

feat: added "allow_reauth" config option for openstack client#11572
srebhan merged 4 commits intoinfluxdata:masterfrom
singamSrikar:master

Conversation

@singamSrikar
Copy link
Copy Markdown
Contributor

@singamSrikar singamSrikar commented Aug 1, 2022 •
edited
Loading

Required for all PRs

resolves #

This solves the issue of "unauthorised access" because of Openstack API access token expiration.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 1, 2022
@singamSrikar
Copy link
Copy Markdown
Contributor Author

singamSrikar commented Aug 1, 2022

@powersj Hey, please review this PR.

srebhan
srebhan reviewed Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @singamSrikar! I wonder if the current behavior is really wanted or if this is simply a bug that should be fixed!?

@srebhan srebhan self-assigned this Aug 1, 2022
@srebhan srebhan added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Aug 1, 2022
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Aug 2, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@singamSrikar
Copy link
Copy Markdown
Contributor Author

singamSrikar commented Aug 2, 2022

@srebhan updated the code with suggestions, please review. Thanks.

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 2, 2022
srebhan
srebhan approved these changes Aug 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the quick response @singamSrikar!

@srebhan srebhan merged commit a049738 into influxdata:master Aug 2, 2022
@sjwang90 sjwang90 mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srebhan srebhan srebhan approved these changes

+1 more reviewer

@powersj powersj powersj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srebhan srebhan

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@singamSrikar @powersj @srebhan