Output cloudrun addition#10369
Closed
crflanigan wants to merge 98 commits intoinfluxdata:masterfrom
homedepot:output-cloudrun-addition
Closed
Output cloudrun addition#10369crflanigan wants to merge 98 commits intoinfluxdata:masterfrom homedepot:output-cloudrun-addition
crflanigan wants to merge 98 commits intoinfluxdata:masterfrom
homedepot:output-cloudrun-addition
Conversation
Included TODOs with outstanding items. The main outstanding items are refreshing the auth token, and adding test cases.
Corrected bug that caused "field corresponding to `timeout' in cloudrun.CloudRun cannot be set through TOML"
removed some TODOs, print statements, and unneeded code.
DONE: - Working basic Write test case - Removed deprecated golang.org/x/oauth2/jws package - Removed some print statements TODO: - More test cases to achieve more coverage
powersj
reviewed
Jan 4, 2022
powersj
reviewed
Jan 4, 2022
powersj
reviewed
Jan 4, 2022
Contributor
|
@srebhan could you take a look at this please :) I think I am generally happy with where this got to. |
Member
|
@powersj your whish is my command. ;-) |
srebhan
reviewed
Jan 11, 2022
Member
srebhan
left a comment
There was a problem hiding this comment.
@crflanigan, @zachmares and @powersj I think this looks quite nicely already, but do have some comments... One bigger question is if it makes sense to merge this into the more general oauth implementation for other plugins to also benefit. We could add a CreateCloundRunClient function there containing this implementation...
TODO: key func for parsing jwt
Thomas Casteleyn requested this addition
…ot/telegraf into google-api-auth
rebased upstream/master and reset --hard origin/master
For Google API auth, the audience is the URL of the service getting invoked.
Contributor
Author
|
Closing this as the scope of this PR has drifed quite a bit based on feedback from the community. We will open a new PR with the updated code and feature description. |
Member
|
@crflanigan let me know about the new PR! |
Contributor
Author
|
New PR can be found here |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #7913
Added an output plugin for Google Cloud Run which implements the OAuth 2.0 protocol enabling the Telegraf agent to send encrypted metric payloads into a time series metrics proxy running in GCP.