test: add test for mysql gatherGlobalVariables using sql-mock#10036
Closed
fxedel wants to merge 3 commits intoinfluxdata:masterfrom
Closed
test: add test for mysql gatherGlobalVariables using sql-mock#10036fxedel wants to merge 3 commits intoinfluxdata:masterfrom
fxedel wants to merge 3 commits intoinfluxdata:masterfrom
Conversation
Contributor
|
😄 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here! 🐯Artifact URLs |
MyaLongmire
approved these changes
Nov 1, 2021
Contributor
MyaLongmire
left a comment
There was a problem hiding this comment.
Thank you for adding more tests!
Contributor
|
Hi, Would love to take more tests, however, it looks like the PR tests and lint are failing. Can you take a look at the failures? Thanks! |
Contributor
|
👍 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
Contributor
|
@fxedel would you be willing to rebase this PR so we can get this landed? Thanks! |
Contributor
|
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Updated associated README.md.See #8561
Add a test that doesn't need a real database connection (by using sql-mock) and asserts proper parsing of the SQL query result.
I already found some issues with the version tag by adding this test, but I'd recommend adding the tests first and fixing the issues afterwards.