Skip to content

ping plugin broken by commit c237989 #8805

@0x0a11c0de

Description

@0x0a11c0de

This commit introduced two problems:

  1. It sets the go-ping timeout to the per-ping timeout value. The timeout in go-ping is not the per-ping timeout. It is the timeout for exiting the pinger. The go-ping timeout should be set to the deadline value. go-ping does not appear to have a way to set the per-ping timeout value.
  2. It removed the sorting of the rtts before calculating the percentiles, which means the percentile calculation cannot work.

Metadata

Metadata

Assignees

Labels

area/pingbugunexpected problem or unintended behavior

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions