Skip to content

[Wavefront Output Plugin] make internal sender buffer size configurable #7409

@lihaiswu

Description

@lihaiswu

Feature Request

Make internal sender buffer size configurable in Wavefront Output Plugin

Proposal:

Current behavior:

Current defaultBufferSize is 50000 in wavefront sdk https://github.com/wavefrontHQ/wavefront-sdk-go/blob/master/senders/configs.go#L5
senders/configs.go:5 . When user configure telegraf with metric_buffer_limit exceed 50000, then extra metrics will be failed to write wavefront because of buffer full returned.

Desired behavior:

Wavefront Output Plugin should make buffer size configurable to align with telegraf metric_buffer_limit. Otherwise, it's a limitation of Wavefront Output Plugin which can only accept maximum 50000 metrics.

Use case:

  • Set metric_buffer_limit to 250000 in telegraf.conf.

  • Telegraf write 51228 metrics to Wavefront

  • Only 50000 metrics are accepted, extra 1228 are failed due to "Wavefront sending error: buffer full, dropping line"

2020-04-24T20:38:11Z D! [outputs.wavefront] Buffer fullness: 51228 / 250000 metrics 2020-04-24T20:38:38Z D! [outputs.wavefront] Wrote batch of 1000 metrics in 14.219747ms 2020-04-24T20:38:38Z D! [outputs.wavefront] Wrote batch of 1000 metrics in 11.761473ms 2020-04-24T20:38:38Z D! [outputs.wavefront] Wrote batch of 1000 metrics in 10.877892ms 2020-04-24T20:38:38Z D! [outputs.wavefront] Wrote batch of 1000 metrics in 16.069646ms .... 2020-04-24T20:38:39Z D! [outputs.wavefront] Wrote batch of 1000 metrics in 10.612196ms 2020-04-24T20:38:39Z D! [outputs.wavefront] Buffer fullness: 1228 / 250000 metrics 2020-04-24T20:38:39Z E! [agent] Error writing to outputs.wavefront: Wavefront sending error: buffer full, dropping line

Metadata

Metadata

Assignees

Labels

area/wavefrontbugunexpected problem or unintended behavior

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions