fix: Issue/604 #717
Merged
fix: Issue/604 #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
=========================================
Coverage 88.37% 88.37%
- Complexity 784 786 +2
=========================================
Files 174 174
Lines 7089 7091 +2
Branches 390 391 +1
=========================================
+ Hits 6265 6267 +2
Misses 698 698
Partials 126 126 ☔ View full report in Codecov by Sentry. |
bednar
approved these changes
May 7, 2024
Contributor
bednar
left a comment
There was a problem hiding this comment.
Hi @KYankee6,
Thank you for your Pull Request! 👍 I've gone ahead and addressed the code style errors that were causing our checks to fail. With those adjustments, all our checks have now passed successfully.
Everything looks good to me (LGTM)! 🚀 We're all set to move forward. Your contribution is greatly appreciated, and it's ready to make an impact.
Best regards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #604
can tested other repos because there are unwanted infrastructure dependency (why it needs to connect localhost:9999?)
Proposed Changes
in flux-dsl, if ColumnRestriction has custom() function and it is using regular expression operator(such as "=~"), then it does not use double quotes.
Checklist
mvn testcompletes successfully