fix: Issue/623 #706
Merged
fix: Issue/623 #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bednar
approved these changes
Apr 25, 2024
Contributor
bednar
left a comment
There was a problem hiding this comment.
Thanks for your PR! 👍
LGTM 🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #706 +/- ##
============================================
+ Coverage 88.33% 88.37% +0.04%
- Complexity 771 784 +13
============================================
Files 174 174
Lines 7088 7089 +1
Branches 389 390 +1
============================================
+ Hits 6261 6265 +4
+ Misses 700 698 -2
+ Partials 127 126 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #623
Proposed Changes
Change the way in which
InfluxDBClientOptionsprepares a parsed URL, so that IPv6 addresses will be detected and preserved.Checklist
mvn testcompletes successfully