Skip to content

Conversation

@karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Apr 22, 2024

Closes #662

Proposed Changes

Adds to fluxDSL:

  • ElapsedFlux.java - function type, to serialize flux method |> elapsed(unit)
  • In Flux.java - four ways of using this type
    • elapsed() - with a default ChronUnit.Millis
    • elapsed(ChronoUnit) - to measure the elapsed time in the passed ChronoUnit
    • elapsed(units, ChronoUnit) - to measure the elapsed time in the passed unit count of the passed ChronoUnit
    • elapsed(TimeInterval) - to measure the elapsed time based on the units of the passed TimeInterval
  • Tests for these

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested a review from bednar April 22, 2024 14:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (caaa861) to head (ff71ced).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #705      +/-   ##
============================================
+ Coverage     88.33%   88.34%   +0.01%     
- Complexity      779      784       +5     
============================================
  Files           173      174       +1     
  Lines          7078     7088      +10     
  Branches        389      389              
============================================
+ Hits           6252     6262      +10     
  Misses          699      699              
  Partials        127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@karel-rehor karel-rehor merged commit 1b10317 into master Apr 23, 2024
@karel-rehor karel-rehor deleted the issue/662 branch April 23, 2024 07:51
@bednar bednar added this to the 7.1.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for elapsed in the Flux DSL

4 participants