fix: Issue/684 #704
Merged
fix: Issue/684 #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bednar
requested changes
Apr 19, 2024
Comment on lines
78
to
84
| "\n" + | ||
| "name,tags,key\n" + //emulate SHOW SERIES response | ||
| ",,temperature\n" + | ||
| ",,\"pressure\"\n" + | ||
| ",,humid\n" + | ||
| ",,\"temperature,locale=nw002,device=rpi5_88e1\"" | ||
| ); |
Contributor
There was a problem hiding this comment.
Please add this as new test, something like testShowSeries. It will be better for future maintenance of InfluxQLQueryApiImplTest.java.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #704 +/- ##
=========================================
Coverage 88.33% 88.33%
+ Complexity 779 777 -2
=========================================
Files 173 173
Lines 7078 7078
Branches 389 389
=========================================
Hits 6252 6252
Misses 699 699
Partials 127 127 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #684
Proposed Changes
Fixes logic in check of marker for end of table in CSV stream.
InfluxQLQueryApiImpl:129Checklist
mvn testcompletes successfully