Skip to content

Conversation

@bednar
Copy link
Contributor

@bednar bednar commented Jan 22, 2024

Closes #649

Proposed Changes

Migrate influxdb-spring from Spring Boot v2 to v3, Spring to v6.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50e1142) 88.35% compared to head (41e8650) 88.33%.

❗ Current head 41e8650 differs from pull request most recent head 82547fb. Consider uploading reports for the commit 82547fb to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #673      +/-   ##
============================================
- Coverage     88.35%   88.33%   -0.03%     
- Complexity      777      779       +2     
============================================
  Files           173      173              
  Lines          7078     7078              
  Branches        393      389       -4     
============================================
- Hits           6254     6252       -2     
  Misses          699      699              
- Partials        125      127       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar marked this pull request as ready for review January 23, 2024 14:28
@bednar bednar requested a review from karel-rehor January 29, 2024 08:00
String userAgent = recordedRequest.getHeader("User-Agent");

Assertions.assertThat(userAgent).startsWith("influxdb-client-java/7.");
String currentVersion = UserAgentInterceptor.class.getPackage().getImplementationVersion();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test change here. Jakub, does this work for you? Does it not defeat Utku Aydin's intent for this assertion?

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK. To check the build of this branch locally I added a change to WriteApiTest.userAgent():1004-1025. If this change does not negatively impact earlier intentions for this test, I think this PR can be merged.

@bednar bednar merged commit c28b9db into master Jan 29, 2024
@bednar bednar deleted the spring-boot-3 branch January 29, 2024 20:04
@bednar bednar added this to the 7.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

influxdb-spring 6.10.0 does not work with spring boot 3.2.0

5 participants