fix: do not hard-code content-encoding on writes#519
Conversation
Because the content-encoding was always getting set, we were never gzip encoding data. The content-encoding should only be set by the gzip class and only when we gzip data.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #519 +/- ##
============================================
- Coverage 88.51% 88.41% -0.10%
Complexity 779 779
============================================
Files 172 172
Lines 7008 7008
Branches 380 380
============================================
- Hits 6203 6196 -7
- Misses 686 693 +7
Partials 119 119
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
The AbstractWriteClient and AbstractWriteBlockingClient the We can leave the Here is a screenshot of a local capture with gzip enabled. Note Content-Encoding is correctly set:
Here is a screenshot of a local capture with gzip disabled. Note Content-Encoding is not present since we are not encoding the content:
|
Because the content-encoding was always getting set, we were never gzip encoding data. The content-encoding should only be set by the gzip class and only when we gzip data.
fixes: #521