Conversation
* feat: add CheckedClose test helper
Add CheckedClose test helper to improve readability of the following
pattern in tests.
```
defer func() {
require.NoError(t, c.Close())
}()
```
This can now be replaced with `defer CheckedClose(t, c)()`.
* feat: add CheckedCloseOnce
Add CheckedCloseOnce test helper function to create close functions
that check for errors and only call the underlying Close method once.
Clean chery-pick from master-1.x.
(cherry picked from commit 093bd3f)
devanbenz
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CheckedClose test helper to improve readability of the following pattern in tests.
This can now be replaced with
defer CheckedClose(t, c)().Add CheckedCloseOnce test helper function to create close functions that check for errors and only call the underlying Close method once.
Clean chery-pick from master-1.x.
(cherry picked from commit 093bd3f)