Skip to content

feat: Updates post-install for linux package builds#27003

Merged
gwossum merged 1 commit into2.8from
gw/27002/post-install
Dec 2, 2025
Merged

feat: Updates post-install for linux package builds#27003
gwossum merged 1 commit into2.8from
gw/27002/post-install

Conversation

@gwossum
Copy link
Copy Markdown
Member

@gwossum gwossum commented Dec 2, 2025

Nearly clean cherry-pick from main-2.x. Final result is identical to main-2.x.

Co-authored-by: Brandon Pfeifer bpfeifer@influxdata.com
(cherry picked from commit 0f4cd4e)

Closes: #27002

Nearly clean cherry-pick from main-2.x. Final result is identical to
main-2.x.

Co-authored-by: Brandon Pfeifer <bpfeifer@influxdata.com>
(cherry picked from commit 0f4cd4e)

Closes: #27002
@gwossum gwossum self-assigned this Dec 2, 2025
Copy link
Copy Markdown
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

rpm:
recommends:
- influxdata-archive-keyring
- influxdata-archive-keyring No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a newline to terminate the file?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I see this pretty frequently when Linux editors add the trailing newline but OSX do not. The file worked before and will work after.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like CircleCI cared that there was no newline.

@gwossum gwossum merged commit 40a6332 into 2.8 Dec 2, 2025
25 checks passed
@gwossum gwossum deleted the gw/27002/post-install branch December 2, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants