fix: Resolves RLock() leakage in Store.DeleteSeries() (#26647)#26852
Merged
fix: Resolves RLock() leakage in Store.DeleteSeries() (#26647)#26852
Conversation
Taking a look at some of our new DeleteSeries changes I'm seeing two paths in which we can escape the function without releasing the lock We hold the lock here 40ec5b0/tsdb/store.go#L1652 And then within this code block we can return errors without releasing the lock: 40ec5b0/tsdb/store.go#L1665-L1682 We do not log out the errors on the server side and bubble up by returning the error via the http handler to the client 40ec5b0/services/httpd/handler.go#L1060-L1064 (cherry picked from commit c67028a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking a look at some of our new DeleteSeries changes I'm seeing two paths in which we can escape the function without releasing the lock
We hold the lock here 40ec5b0/tsdb/store.go#L1652
And then within this code block we can return errors without releasing the lock:
40ec5b0/tsdb/store.go#L1665-L1682
We do not log out the errors on the server side and bubble up by returning the error via the http handler to the client
40ec5b0/services/httpd/handler.go#L1060-L1064
(cherry picked from commit c67028a)