feat: Adds time_format param for httpd (#26596)#26833
Merged
Conversation
* feat: Adds time_format param for httpd * This PR will add a time_format parameter which takes in the value "epoch" or "rfc3339". The default will be "epoch" depending on the value output timestamps will be formatted in epoch or rfc3339. Closes FR#615 * feat: Adding some changes * error if incorrect param * update naming for converter function * combine tests * chore: fmt'ing * feat: A few modifications * Rename convertToRfc3339Nano to convertToTimeFormat * allow time formatting to be passed as parameter * adjust error handling to use already defined timeFormats * merge test data for test cases to reduce boilerplate (cherry picked from commit 57da7aa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Adds time_format param for httpd
This PR will add a time_format parameter which takes in the value "epoch" or "rfc3339". The default will be "epoch" depending on the value output timestamps will be formatted in epoch or rfc3339.
Closes FR#615
feat: Adding some changes
error if incorrect param
update naming for converter function
combine tests
chore: fmt'ing
feat: A few modifications
Rename convertToRfc3339Nano to convertToTimeFormat
allow time formatting to be passed as parameter
adjust error handling to use already defined timeFormats
merge test data for test cases to reduce boilerplate
(cherry picked from commit 57da7aa)